[fix] allow the user to overwrite the no_input flag to pip
#5036
Conversation
| @@ -518,7 +518,7 @@ def pip_options(self): | |||
| pip_options, _ = self.pip_command.parser.parse_args(self.pip_args) | |||
| pip_options.cache_dir = self.project.s.PIPENV_CACHE_DIR | |||
| pip_options.no_python_version_warning = True | |||
| pip_options.no_input = True | |||
| pip_options.no_input = self.project.settings.get("disable_pip_input", True) | |||
There was a problem hiding this comment.
I think this is going to at a minimum require some documentation around how to specify this in the Pipfile and what it does.
There was a problem hiding this comment.
I tried figuring out how the documentation is built but failed. Can you point me in the right direction, @matteius?
There was a problem hiding this comment.
Sure -- so you have to go into the docs directory and there is a separate requirements.txt in there to install using pip -r requirements.txt. I think after that you should just have to run make html to build the html docs. Going from memory here but I did it not so long ago ...
There was a problem hiding this comment.
I can't get the pipfile to show as syntax. But the doc is added. Maybe you can take it from here, @matteius ?
There was a problem hiding this comment.
since its in your fork, best I can do is address any formatting in a followup PR. I'll at least get this merged now.
this is required if you want to e.g. use keyring to authenticate against Google Artifact Registry
ghost
deleted the
this is required if you want to e.g. use a keyring to authenticate
against Google Artifact Registry. fixes #4706
Thank you for contributing to Pipenv!
The issue
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.
If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.
The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.